Issue 9146049: Test.dart running browser tests on Windows!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9146049: Test.dart running browser tests on Windows! (Closed)

Created:
8 years, 11 months ago by Emily Fortuna

Modified:
8 years, 11 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang), William Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More fixes for test.dart to run browser tests on Windows! Committed: https://code.google.com/p/dart/source/detail?r=3585

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1 2	2 chunks	+21 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://chromiumcodereview.appspot.com/9146049/diff/5001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://chromiumcodereview.appspot.com/9146049/diff/5001/tools/testing/dart/test_suite.dart#newcode915 tools/testing/dart/test_suite.dart:915: String postfix = executableSuffix(configuration['component']); Now that I see ...

8 years, 11 months ago (2012-01-25 00:38:07 UTC) #2

LGTM.

Expand Messages | Collapse Messages

Issue 9146049: Test.dart running browser tests on Windows! (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages