More setting of symbols on identifiers

More setting of symbols on identifiers

Konstantin was right in http://codereview.chromium.org/9150044/ 
I should have included a unit test.  This change includes a 
hand written unit test for identifiers being set properly on class/interface
definition variants, and fixes to the ResolverAuditVisitor (it was not 
catching many problems in just those cases).

Committed: https://code.google.com/p/dart/source/detail?r=3459

[scheglov, 2012-01-20 17:24:18]

https://chromiumcodereview.appspot.com/9138023/diff/3007/compiler/javatests/c...
File
compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/9138023/diff/3007/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java:95:
assertEquals(A.getSymbol(), A.getName().getSymbol());
assertSame?

Do we anticipate using equal, but not same Element-s?
Doing this can be sign of using extra memory.

[zundel, 2012-01-20 17:40:45]

Updated patch

https://chromiumcodereview.appspot.com/9138023/diff/3007/compiler/javatests/c...
File
compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/9138023/diff/3007/compiler/javatests/c...
compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java:95:
assertEquals(A.getSymbol(), A.getName().getSymbol());
On 2012/01/20 17:24:18, scheglov wrote:
> assertSame?
> 
> Do we anticipate using equal, but not same Element-s?
> Doing this can be sign of using extra memory.

Good point.

[scheglov, 2012-01-20 17:48:36]

LGTM