Issue 9121060: Fix listing of source scripts in debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9121060: Fix listing of source scripts in debugger (Closed)

Created:
8 years, 11 months ago by hausner

Modified:
8 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix listing of source scripts in debugger The cache of loaded scripts must be initialized to null when loading from a snapshot. Fix for issue 1345. Committed: https://code.google.com/p/dart/source/detail?r=3673

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/vm/raw_object_snapshot.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/9121060/diff/1/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): http://codereview.chromium.org/9121060/diff/1/runtime/vm/raw_object_snapshot.cc#newcode747 runtime/vm/raw_object_snapshot.cc:747: writer->Write<int8_t>(ptr()->load_state_); Maybe also add a comment here too ...

8 years, 11 months ago (2012-01-27 22:50:53 UTC) #2

hausner

8 years, 11 months ago (2012-01-27 23:01:04 UTC) #3

Thank you.

http://codereview.chromium.org/9121060/diff/1/runtime/vm/raw_object_snapshot.cc
File runtime/vm/raw_object_snapshot.cc (right):

http://codereview.chromium.org/9121060/diff/1/runtime/vm/raw_object_snapshot....
runtime/vm/raw_object_snapshot.cc:747:
writer->Write<int8_t>(ptr()->load_state_);
On 2012/01/27 22:50:53, asiva wrote:
> Maybe also add a comment here too that we do not serialize the cache of loaded
> scripts.

Done.

Expand Messages | Collapse Messages