Issue 9117010: Fix frogsh + Windows + test.dart take 2

Issue 9117010: Fix frogsh + Windows + test.dart take 2 (Closed)

Created:
8 years, 11 months ago by Emily Fortuna

Modified:
8 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix frogsh + Windows + test.dart take 2 Committed: https://code.google.com/p/dart/source/detail?r=3522

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -17 lines)			Patch
M	client/tools/buildbot_annotated_steps.py	View	1	3 chunks	+19 lines, -5 lines	0 comments	Download
A	frog/frogsh.bat	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	frog/library.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/scripts/bootstrap/frogsh_bootstrap_wrapper.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	3 chunks	+19 lines, -7 lines	0 comments	Download
M	tools/testing/perf_testing/perf_README.txt	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	tools/testing/run_selenium.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/9117010/diff/3017/client/tools/buildbot_annotated_steps.py File client/tools/buildbot_annotated_steps.py (right): https://chromiumcodereview.appspot.com/9117010/diff/3017/client/tools/buildbot_annotated_steps.py#newcode187 client/tools/buildbot_annotated_steps.py:187: return subprocess.call([sys.executable + ' ' + Fix from build ...

8 years, 11 months ago (2012-01-23 23:04:46 UTC) #1

Siggi Cherem (dart-lang)

8 years, 11 months ago (2012-01-23 23:26:28 UTC) #2

lgtm (with comment below)

https://chromiumcodereview.appspot.com/9117010/diff/3017/client/tools/buildbo...
File client/tools/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9117010/diff/3017/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:68: shell=True)
add this only in windows too?

https://chromiumcodereview.appspot.com/9117010/diff/3017/client/tools/buildbo...
client/tools/buildbot_annotated_steps.py:187: return
subprocess.call([sys.executable + ' ' +
On 2012/01/23 23:04:46, Emily Fortuna wrote:
> Fix from build break this morning.

Add a comment here saying why we need to set shell=True.

I actually prefer your suggestion from earlier today of doing this differently
on each system, it seems more aligned with the special comment you are about to
add :)
if 'windows' in name:
   os.environ['PATH'] = ....
   subprocess.call([x + ' ' + y], env=os.environ, shell=True)
else:
   subprocess.call([x, y])

Expand Messages | Collapse Messages