Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 9113061: Reapply r3590 with frog fixes (Closed)

Created:
8 years, 11 months ago by jimhug
Modified:
8 years, 11 months ago
Reviewers:
Jennifer Messerly, sra1
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Reapply r3590 with frog fixes Committed: https://code.google.com/p/dart/source/detail?r=3599

Patch Set 1 #

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2202 lines, -79 lines) Patch
M client/dom/frog/dom_frog.dart View 1 18 chunks +1052 lines, -26 lines 0 comments Download
M client/dom/generated/src/frog/CanvasPixelArray.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Float32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Float64Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/HTMLCollection.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Int16Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Int32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Int8Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/MediaList.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/NamedNodeMap.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/NodeList.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/StyleSheetList.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/TouchList.dart View 1 1 chunk +68 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint16Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Uint32Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Uint8Array.dart View 1 1 chunk +69 lines, -2 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 4 chunks +19 lines, -5 lines 0 comments Download
M client/dom/src/_Lists.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download
A client/dom/templates/dom/frog/immutable_list_mixin.darttemplate View 1 1 chunk +67 lines, -0 lines 0 comments Download
M frog/gen.dart View 2 chunks +13 lines, -12 lines 0 comments Download
M frog/minfrog View 2 chunks +3 lines, -6 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jimhug
8 years, 11 months ago (2012-01-25 15:33:22 UTC) #1
TBR=sra

This fixes the bug that forced Stephen to revert r3590 last night and includes
his changes to ensure the fix will hold.

I also uncovered a significant type mistmatch issue between the isolate code in
frog which wanted to pass a JSON array to postMessage and the Worker.postMessage
method that wouldn't accept it.  This mismatch has been present for a while and
was the reason that several isolate tests were failing in checked mode.  I
"fixed" the issue for now by manually editing the generated dom_frog file and
changing these methods to accept var.  I'm sure this isn't the right long-term
answer, but this greatly increases our isolate test coverage today.

Powered by Google App Engine
This is Rietveld 408576698