Fix for alphanumerics following braces.

Fix for alphanumerics following braces.

BUG=3
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/dart_lint/commit/e7c35b3b75334d28c59c20fb4dd63f2bcb8aac33

[pquitslund, 2015-02-05 01:11:22]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[pquitslund, 2015-02-05 01:11:23]

While the message is provisional and a WIP, comments welcome.  Otherwise,
feedback on my visitor implementation appreciated.

Thanks!

[scheglov, 2015-02-05 01:38:08]

LGTM

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
File lib/src/rules/unnecessary_brace_in_string_interp.dart (right):

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:29: class Visitor extends
SimpleAstVisitor<Object> {
Remove <Object>.

[Brian Wilkerson, 2015-02-05 01:38:42]

LGTM

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
File lib/src/rules/unnecessary_brace_in_string_interp.dart (right):

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:16: not need braces.
Don't include end-of-line characters in the message. Clients are responsible for
wrapping messages where necessary.

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:40:
reporter.reportErrorForNode(new LintCode(name, msg), expression, []);
I would recommend defining static constant fields in LintCode. I think it makes
it easier to find where messages are being produced when all you're given in a
bug report is the message that was displayed.

[pquitslund, 2015-02-05 03:42:06]

Thanks!

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
File lib/src/rules/unnecessary_brace_in_string_interp.dart (right):

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:16: not need braces.
On 2015/02/05 01:38:42, Brian Wilkerson wrote:
> Don't include end-of-line characters in the message. Clients are responsible
for
> wrapping messages where necessary.

Done.

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:29: class Visitor extends
SimpleAstVisitor<Object> {
On 2015/02/05 01:38:08, scheglov wrote:
> Remove <Object>.

Done.

https://codereview.chromium.org/900093002/diff/20001/lib/src/rules/unnecessar...
lib/src/rules/unnecessary_brace_in_string_interp.dart:40:
reporter.reportErrorForNode(new LintCode(name, msg), expression, []);
On 2015/02/05 01:38:42, Brian Wilkerson wrote:
> I would recommend defining static constant fields in LintCode. I think it
makes
> it easier to find where messages are being produced when all you're given in a
> bug report is the message that was displayed.

Agreed!  That said, if I understand you right, I'm not completely sure how that
would work since LintCode is defined in the analyzer package and the lints are
contributed outside it...

[pquitslund, 2015-02-05 03:43:13]

New patchsets have been uploaded after l-g-t-m from
scheglov@google.com,brianwilkerson@google.com

[pquitslund, 2015-02-05 03:44:13]

Committed patchset #3 (id:40001) manually as
e7c35b3b75334d28c59c20fb4dd63f2bcb8aac33 (presubmit successful).