Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886643002: pkg/protobuf: cleanup and prep for 0.3.5 release (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 10 months ago
Reviewers:
Søren Gjesse, sra1
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup and prep for 0.3.5 release readme cleanup created changelog remove unused members R=sra@google.com Committed: https://github.com/dart-lang/protobuf/commit/c73600be1cf604cce09d560624b003b7ee84fcfa

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
A CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M README.md View 1 chunk +7 lines, -25 lines 0 comments Download
M lib/src/protobuf/coded_buffer_reader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/protobuf/generated_message.dart View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kevmoo
5 years, 10 months ago (2015-01-28 22:35:20 UTC) #2
sra1
https://chromiumcodereview.appspot.com/886643002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://chromiumcodereview.appspot.com/886643002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Allow constants as field initial values as well ...
5 years, 10 months ago (2015-01-28 23:39:14 UTC) #4
sra1
lgtm
5 years, 10 months ago (2015-01-29 00:04:40 UTC) #5
kevmoo
https://chromiumcodereview.appspot.com/886643002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://chromiumcodereview.appspot.com/886643002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Allow constants as field initial values as well ...
5 years, 10 months ago (2015-01-29 00:07:13 UTC) #6
kevmoo
Committed patchset #2 (id:20001) manually as c73600be1cf604cce09d560624b003b7ee84fcfa (presubmit successful).
5 years, 10 months ago (2015-01-29 00:07:22 UTC) #7
Søren Gjesse
5 years, 10 months ago (2015-01-29 07:44:58 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698