Issue 885223002: Bugfix for broken protobuf decoding in case of Uint8List views with non-zero offsets

Issue 885223002: Bugfix for broken protobuf decoding in case of Uint8List views with non-zero offsets (Closed)

Created:
5 years, 10 months ago by kustermann

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse, Siggi Cherem (dart-lang), Chris Bracken

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protobuf.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -33 lines)			Patch
M	CHANGELOG.md	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	lib/src/protobuf/coded_buffer_reader.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/coded_buffer_reader_test.dart	View	1	3 chunks	+53 lines, -28 lines	0 comments	Download

Total messages: 9 (2 generated)

kustermann

PTAL, modified existing test to use List, Uint8List and Uint8List.view

5 years, 10 months ago (2015-01-30 09:59:59 UTC) #7

kustermann

5 years, 10 months ago (2015-01-30 10:26:54 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c6cae3d9cbdffae62bafddd6cfdc5fa4cedc972a (presubmit successful).