Issue 876463003: Simplify some types used in is checks and correct PbList to match the typical signature used by the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
5 years, 11 months ago by Jacob

Modified:
5 years, 10 months ago

Reviewers:
Chris Bracken

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-protobuf.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Simplify some types used in is checks and correct PbList to match the typical signature used by the setRange method. BUG=

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	lib/src/protobuf/generated_message.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/src/protobuf/pb_list.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jacob

Simplify some types used in is checks and correct PbList to match the typical signature ...

5 years, 11 months ago (2015-01-27 03:49:37 UTC) #2

lgtm