Issue 870183005: Clean up benchmark code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 870183005: Clean up benchmark code. (Closed)

Created:
5 years, 10 months ago by Bob Nystrom

Modified:
5 years, 10 months ago

Reviewers:
pquitslund, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Clean up benchmark code. Add a dedicated before and after so I can see when other formatter changes affect the benchmark output. R=kevmoo@google.com Committed: cd5dee8c0eac3a786f3526880445de6082174c08

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -1034 lines)			Patch
A +	benchmark/after.dart.txt	View	15 chunks	+41 lines, -135 lines	0 comments	Download
A +	benchmark/before.dart.txt	View	2 chunks	+1 line, -71 lines	0 comments	Download
M	benchmark/benchmark.dart	View	5 chunks	+24 lines, -828 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

5 years, 10 months ago (2015-02-02 17:13:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cd5dee8c0eac3a786f3526880445de6082174c08 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages