Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 844653002: Format enums. Fix #120. (Closed)

Created:
5 years, 11 months ago by Bob Nystrom
Modified:
5 years, 11 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Format enums. Fix #120. BUG=https://github.com/dart-lang/dart_style/issues/120 R=pquitslund@google.com Committed: 6a0abc7c21f3b3a1812977ee12ea81cab4cfca95

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M lib/src/dart_formatter.dart View 1 chunk +1 line, -0 lines 2 comments Download
M lib/src/source_visitor.dart View 1 chunk +25 lines, -2 lines 0 comments Download
A test/splitting/enums.unit View 1 chunk +19 lines, -0 lines 0 comments Download
A test/whitespace/enums.unit View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
Before I land this, I'm going to send out another patch to bump the version ...
5 years, 11 months ago (2015-01-08 01:13:01 UTC) #2
pquitslund
LGTM. Good stuff. As for revving the # in DEPS, do keep me posted, though ...
5 years, 11 months ago (2015-01-08 04:49:26 UTC) #3
Bob Nystrom
https://chromiumcodereview.appspot.com/844653002/diff/1/lib/src/dart_formatter.dart File lib/src/dart_formatter.dart (right): https://chromiumcodereview.appspot.com/844653002/diff/1/lib/src/dart_formatter.dart#newcode150 lib/src/dart_formatter.dart:150: parser.parseEnum = true; On 2015/01/08 04:49:25, pquitslund wrote: > ...
5 years, 11 months ago (2015-01-08 17:35:35 UTC) #4
Bob Nystrom
5 years, 11 months ago (2015-01-08 17:37:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a0abc7c21f3b3a1812977ee12ea81cab4cfca95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698