Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 816693002: Add string versions of User/Pickled objects to datastore models (Closed)

Created:
6 years ago by kustermann
Modified:
6 years ago
Reviewers:
wibling, Søren Gjesse
Base URL:
https://github.com/dart-lang/pub-dartlang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add string versions of User/Pickled objects to datastore models On newly created objects Package.uploaders, PackageVersion.uploader/readme/changelog will have corresponding String variants. After a batch processing update of old models, we can enforce the usage of the new properties (and drop the old ones). R=sgjesse@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/16efcbb5a41e916d0aea3cbe109faf2224bf1a11

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use db.Text(encoding="utf-8") #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M app/handlers/api/package_uploaders.py View 2 chunks +2 lines, -0 lines 0 comments Download
M app/handlers/api/package_versions.py View 1 chunk +2 lines, -0 lines 0 comments Download
M app/handlers/package_uploaders.py View 2 chunks +2 lines, -0 lines 0 comments Download
M app/handlers/package_versions.py View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/package.py View 5 chunks +20 lines, -0 lines 0 comments Download
M app/models/package_version.py View 1 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kustermann
I plan on uploading a new appengine version and use this version as PUB_HOSTED_URL and ...
6 years ago (2014-12-18 14:28:17 UTC) #2
kustermann
6 years ago (2014-12-18 14:28:24 UTC) #4
Søren Gjesse
lgtm https://chromiumcodereview.appspot.com/816693002/diff/1/app/models/package_version.py File app/models/package_version.py (right): https://chromiumcodereview.appspot.com/816693002/diff/1/app/models/package_version.py#newcode91 app/models/package_version.py:91: if self.readme: Not related to this change, but ...
6 years ago (2014-12-18 14:47:37 UTC) #5
kustermann
Please take another look if you want to, otherwise I'll start landing this. https://chromiumcodereview.appspot.com/816693002/diff/1/app/models/package_version.py File ...
6 years ago (2014-12-18 15:04:41 UTC) #7
Søren Gjesse
LGTM
6 years ago (2014-12-18 15:14:36 UTC) #8
kustermann
6 years ago (2014-12-18 15:20:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
16efcbb5a41e916d0aea3cbe109faf2224bf1a11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698