Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 815973002: Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties (Closed)

Created:
6 years ago by kustermann
Modified:
6 years ago
Reviewers:
Søren Gjesse
Base URL:
https://github.com/dart-lang/pub-dartlang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove legacy Package.uploaders PackageVersion.{uploader,readme,changelog} properties R=sgjesse@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/d95843104ec74025993a1e061767ef38fa65c67a

Patch Set 1 #

Patch Set 2 : Small fix in changelog/readme handling for new uploads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -82 lines) Patch
M app/handlers/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M app/handlers/api/package_uploaders.py View 2 chunks +12 lines, -13 lines 0 comments Download
M app/handlers/api/package_versions.py View 3 chunks +3 lines, -4 lines 0 comments Download
M app/handlers/package_uploaders.py View 2 chunks +10 lines, -12 lines 0 comments Download
M app/handlers/package_versions.py View 2 chunks +1 line, -3 lines 0 comments Download
M app/models/package.py View 4 chunks +3 lines, -17 lines 0 comments Download
M app/models/package_version.py View 1 8 chunks +18 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
6 years ago (2014-12-19 12:53:06 UTC) #2
Søren Gjesse
lgtm
6 years ago (2014-12-19 13:51:08 UTC) #3
kustermann
6 years ago (2014-12-19 13:56:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d95843104ec74025993a1e061767ef38fa65c67a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698