Issue 815423003: Don't put spaces in empty for loop clauses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 815423003: Don't put spaces in empty for loop clauses. (Closed)

Created:
5 years, 11 months ago by Bob Nystrom

Modified:
5 years, 11 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't put spaces in empty for loop clauses. Fix #132. BUG=https://github.com/dart-lang/dart_style/issues/132 R=pquitslund@google.com Committed: 6c8fcc6f71899df295d37cf96ad05d13ef3b5c57

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -20 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/source_visitor.dart	View	1 chunk	+14 lines, -18 lines	0 comments	Download
A	test/regression/132.stmt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/whitespace/for.stmt	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

5 years, 11 months ago (2015-01-14 23:51:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6c8fcc6f71899df295d37cf96ad05d13ef3b5c57 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages