Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 813063002: Remove encoding='utf-8' parameter. (Closed)

Created:
6 years ago by kustermann
Modified:
6 years ago
Reviewers:
wibling
Base URL:
https://github.com/dart-lang/pub-dartlang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove encoding='utf-8' parameter. The Text constructor forbits a encoding parameter for unicode strings :-/ R=wibling@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/3074aa160e61df15d1f088d9607ce56dd0fd35ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M app/models/package_version.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kustermann
6 years ago (2014-12-18 15:43:18 UTC) #2
wibling
lgtm
6 years ago (2014-12-18 15:44:14 UTC) #3
kustermann
6 years ago (2014-12-18 15:44:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3074aa160e61df15d1f088d9607ce56dd0fd35ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698