Handle complex expression nesting correctly.

Handle complex expression nesting correctly.

Previously, the formatter would get confused if it didn't indent enough
for several levels of expression nesting which later turned out to be
needed by later lines.

This addresses that. It does negatively impact perf (about 3x) but I
hope I can regain some of that in later optimizations.

Fixes #49, #66, #75, #83, and #84.

R=pquitslund@google.com

Committed: 50b9d91b6c7aa57196d4a434533b2e6e3cea0de6

[Bob Nystrom, 2014-12-15 20:35:11]

rnystrom@google.com changed reviewers:
+ pquitslund@google.com

[Bob Nystrom, 2014-12-15 20:35:11]

Sorry for the very large patch. It took a bunch of changes to get it back to
passing all the tests with as little perf regression as possible.

[pquitslund, 2014-12-15 21:40:24]

LGTM.

Not surprised about the perf hit.  It'll be interesting to see if you can winnow
it down.

Again: love the tests as documentation.  Easy to bounce between then and
implementation to see the big picture.

[Bob Nystrom, 2014-12-15 23:21:32]

On 2014/12/15 21:40:24, pquitslund wrote:
> LGTM.
> 
> Not surprised about the perf hit.  It'll be interesting to see if you can
winnow
> it down.

When I first got this working, it was 10x slower than before (!). It's down to
about 2.5x right now, which is still within the bounds of good enough. There are
a couple of TODOs in there for optimizations I can do that I think will get it
back to where it was.

> Again: love the tests as documentation.  Easy to bounce between then and
> implementation to see the big picture.

:D

- bob

[Bob Nystrom, 2014-12-15 23:23:00]

Committed patchset #1 (id:1) manually as
50b9d91b6c7aa57196d4a434533b2e6e3cea0de6 (presubmit successful).