Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 711023004: Discard a trailing split at the end of the line. (Closed)

Created:
6 years, 1 month ago by Bob Nystrom
Modified:
6 years, 1 month ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Visibility:
Public.

Description

Discard a trailing split at the end of the line. Fixes #13. BUG=https://github.com/dart-lang/dart_style/issues/13 R=kevmoo@google.com Committed: fb57ec972f1d37e78acb5a78cfe3321080d6a17b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M lib/src/line_writer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M test/whitespace/classes.unit View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
6 years, 1 month ago (2014-11-10 22:36:59 UTC) #2
kevmoo
lgtm
6 years, 1 month ago (2014-11-10 23:27:47 UTC) #4
Bob Nystrom
6 years, 1 month ago (2014-11-11 00:29:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb57ec972f1d37e78acb5a78cfe3321080d6a17b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698