Update the protocol buffer compiler plug-in library to the latest Dart SDK

Update the protocol buffer compiler plug-in library to the latest Dart SDK

Remove most analyzer warnings (e.g. enum changed to enm).

R=sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/protoc-plugin/commit/1914db2

[Siggi Cherem (dart-lang), 2013-11-11 23:48:02]

I'm not a big fan of 'enm'. I think I prefer the 'isX' format better, another
idea if we just want a quick fix would be to spell it out 'enumeration'

https://chromiumcodereview.appspot.com/68953002/diff/1/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://chromiumcodereview.appspot.com/68953002/diff/1/lib/protobuf_field.dar...
lib/protobuf_field.dart:37: bool get enm => type ==
FieldDescriptorProto_Type.TYPE_ENUM;
to match what we do elsewhere in the Dart libraries, maybe this should be
isEnum?

Similarly, all other boolean getters (isGroup, isMessage, isSingle, isPrimitive,
isOptional, isRequired)?

https://chromiumcodereview.appspot.com/68953002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/68953002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.2.1
0.2.2?

(the change for protobuf_field might be a breaking change)

[Søren Gjesse, 2013-11-12 08:32:23]

https://chromiumcodereview.appspot.com/68953002/diff/1/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://chromiumcodereview.appspot.com/68953002/diff/1/lib/protobuf_field.dar...
lib/protobuf_field.dart:37: bool get enm => type ==
FieldDescriptorProto_Type.TYPE_ENUM;
On 2013/11/11 23:48:02, Siggi Cherem (dart-lang) wrote:
> to match what we do elsewhere in the Dart libraries, maybe this should be
> isEnum?
> 
> Similarly, all other boolean getters (isGroup, isMessage, isSingle,
isPrimitive,
> isOptional, isRequired)?

Agreed, however I will postpone that to a separate CL. There are other style
variations in this code which we should address as well.

https://chromiumcodereview.appspot.com/68953002/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/68953002/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.2.1
On 2013/11/11 23:48:02, Siggi Cherem (dart-lang) wrote:
> 0.2.2?
> 
> (the change for protobuf_field might be a breaking change)

Thanks. Done.

[Søren Gjesse, 2013-11-12 08:32:51]

Committed patchset #2 manually as r1914db2 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-11-12 18:17:11]

even if we don't fix all the other APIs, I prefer not exposing 'enm' as a public
API.

Question: how much people will use this API? If this is something we don't
expect that many users to depend on, then I'm ok if we fix it later, but if not,
I much rather have isEnum or enumeration at this time. My current guess is that
most users depend on protobuf_lib and not so much on the code here. Is that
correct?

[Søren Gjesse, 2013-11-12 22:00:05]

On 2013/11/12 18:17:11, Siggi Cherem (dart-lang) wrote:
> even if we don't fix all the other APIs, I prefer not exposing 'enm' as a
public
> API.
> 
> Question: how much people will use this API? If this is something we don't
> expect that many users to depend on, then I'm ok if we fix it later, but if
not,
> I much rather have isEnum or enumeration at this time. My current guess is
that
> most users depend on protobuf_lib and not so much on the code here. Is that
> correct?

This is not a public API, but internal code for the protoc plug-in, so it i not
exposed at all. I just renamed to get rid of warnings when compiling this into a
standalone script using dart2dart.

[Siggi Cherem (dart-lang), 2013-11-12 22:11:03]

Thanks for clarifying, sgtm!