Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issue 66703002: Change test to use declarations on class mirror (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Visibility:
Public.

Description

Change test to use declarations on class mirror The members constructors and members are going away R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/21caecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M test/reserved_names_test.dart View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-08 13:02:34 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 1 month ago (2013-11-08 19:20:06 UTC) #2
Søren Gjesse
6 years, 11 months ago (2014-01-02 09:02:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21caecb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698