Issue 66383002: Update Dart protoc plugin to latest SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66383002: Update Dart protoc plugin to latest SDK (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master

Visibility:
Public.

More Reviews

Description

Update Dart protoc plugin to latest SDK R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/f154074

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	prepend.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	test/reserved_names_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/66383002/diff/1/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/66383002/diff/1/pubspec.yaml#newcode8 pubspec.yaml:8: sdk: '>=0.8.5' Alternatively, use the latest stable version ...

7 years, 1 month ago (2013-11-08 19:24:11 UTC) #2

Søren Gjesse

7 years, 1 month ago (2013-11-11 10:15:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rf154074 (presubmit successful).

Expand Messages | Collapse Messages