Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 557683002: Make semantic_version.py usable outside of GAE (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
Reviewers:
nweiz, Bob Nystrom
CC:
Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/pub-dartlang@master
Visibility:
Public.

Description

Make semantic_version.py usable outside of GAE Take this if you like, not a big deal. Otherwise I will keep a patch file that I apply on updates. BUG= R=nweiz@google.com Committed: https://github.com/dart-lang/pub-dartlang/commit/4987ef969042e1e3d9e619e1684c54d6fdda038a

Patch Set 1 #

Patch Set 2 : Just use ValueError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M app/models/semantic_version.py View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ricow1
6 years, 3 months ago (2014-09-09 07:17:57 UTC) #2
Bob Nystrom
I'd be fine with just always throwing ValueError here and removing the AppEngine dependency entirely, ...
6 years, 3 months ago (2014-09-09 16:22:19 UTC) #4
nweiz
On 2014/09/09 16:22:19, Bob Nystrom wrote: > I'd be fine with just always throwing ValueError ...
6 years, 3 months ago (2014-09-09 19:12:47 UTC) #5
ricow1
Changed to ValueError
6 years, 3 months ago (2014-09-10 06:02:09 UTC) #6
nweiz
lgtm
6 years, 3 months ago (2014-09-10 18:32:41 UTC) #7
ricow1
6 years, 3 months ago (2014-09-11 12:12:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 4987ef9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698