Issue 372983006: Add file-filter flag to polymer deploy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372983006: Add file-filter flag to polymer deploy (Closed)

Created:
6 years, 5 months ago by ricow1

Modified:
6 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add file-filter flag to polymer deploy Use the filter to not copy in files from .svn directories when doing deploy Please feel free to do this in another way and throw this away - I just want us to get moving on this. Committed: https://code.google.com/p/dart/source/detail?r=38077

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -6 lines)			Patch
M	pkg/polymer/lib/deploy.dart	View	1	5 chunks	+13 lines, -3 lines	0 comments	Download
M	pkg/polymer/lib/src/build/runner.dart	View	1	5 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

I don't really know this code so feel free to do this differently

6 years, 5 months ago (2014-07-08 13:32:10 UTC) #1

Siggi Cherem (dart-lang)

lgtm Seems good to me :) --- I would be OK also just hard coding ...

6 years, 5 months ago (2014-07-08 20:31:07 UTC) #2

ricow1

6 years, 5 months ago (2014-07-09 08:30:16 UTC) #3

Message was sent while issue was closed.

On 2014/07/08 20:31:07, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> Seems good to me :) --- I would be OK also just hard coding a filter for .svn
> since that's the only use we have for it, but this seems good too.
I decided against it for the odd case where some developer is using this and had
.svn in his path name (unlikely, but with the millions and millions of dart
developers out there it is bound to happen :-))

Cheers,
Rico

Expand Messages | Collapse Messages