Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 25708003: Update the protocol buffer compiler plugin to use Int64 from the fixnum package (Closed)

Created:
7 years, 2 months ago by Søren Gjesse
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Visibility:
Public.

Description

Update the protocol buffer compiler plugin to use Int64 from the fixnum package The 64-bit integers in protocol buffer messages now use the Int64 object from the fixnum package for representing 64-bit integers instead of an 8-byte binary buffer. When generating JSON the 64-bit integers in the 53-bit range are written as integers. Larger integeres are still written as strings. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/8f6ddff

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M lib/file_generator.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/protobuf_field.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M prepend.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +3 lines, -3 lines 1 comment Download
M test/file_generator_test.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M test/generated_message_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/json_test.dart View 2 chunks +16 lines, -10 lines 0 comments Download
M test/test_util.dart View 2 chunks +5 lines, -10 lines 0 comments Download
M test/unknown_field_set_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M test/validate_fail_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
This requires https://chromiumcodereview.appspot.com/25634007/ to land.
7 years, 2 months ago (2013-10-02 14:03:15 UTC) #1
Søren Gjesse
Friendly ping.
7 years, 2 months ago (2013-10-04 06:59:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/25708003/diff/1/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/25708003/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.2.0 FYI 0.1.3 would be fine too. ...
7 years, 2 months ago (2013-10-04 18:34:39 UTC) #3
Søren Gjesse
7 years, 2 months ago (2013-10-07 06:53:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r8f6ddff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698