Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 23739004: Update pubspec to pull the protobuf library from pub.dartlang.org (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Visibility:
Public.

Description

Update pubspec to pull the protobuf library from pub.dartlang.org R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/ec62ebe

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Patch Set 3 : Got rid of pubspec.lock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -34 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.lock View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
I uploaded the protobuf package to pub.dartlang.org earlier today.
7 years, 3 months ago (2013-09-05 12:36:34 UTC) #1
Siggi Cherem (dart-lang)
lgtm cool, I think we can now delete the .lock file from the repo then ...
7 years, 3 months ago (2013-09-08 18:52:23 UTC) #2
Søren Gjesse
Committed patchset #3 manually as rec62ebe (presubmit successful).
7 years, 3 months ago (2013-09-09 07:07:30 UTC) #3
Søren Gjesse
On 2013/09/09 07:07:30, Søren Gjesse wrote: > Committed patchset #3 manually as rec62ebe (presubmit successful). ...
7 years, 3 months ago (2013-09-09 09:54:18 UTC) #4
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-09-09 16:57:24 UTC) #5
Message was sent while issue was closed.
lgtm, awesome!

Powered by Google App Engine
This is Rietveld 408576698