Issue 23460011: Remove case expressions that was not compile time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23460011: Remove case expressions that was not compile time constants. (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
dgrove, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master

Visibility:
Public.

Remove case expressions that was not compile time constants. Case expressions must be compile-time constants. This has been in the spec since 0.10. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/483a7ef

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
	M	lib/protobuf_field.dart	View		1 chunk	+17 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

7 years, 3 months ago (2013-09-02 11:17:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r483a7ef (presubmit successful).