Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23224003: move polymer.dart into dart svn (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : add --deploy to todomvc sample #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9836 lines, -1083 lines) Patch
M pkg/pkg.status View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A pkg/polymer/README.md View 1 1 chunk +85 lines, -0 lines 0 comments Download
A + pkg/polymer/bin/dwc.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/polymer/build.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/polymer/example/component/news/test/expected/news_index_test.html.txt View 1 1 chunk +85 lines, -0 lines 0 comments Download
A pkg/polymer/example/component/news/test/news_index_test.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + pkg/polymer/example/component/news/test/test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A pkg/polymer/example/component/news/web/index.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A pkg/polymer/example/component/news/web/news-component.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/polymer/example/scoped_style/index.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/polymer/example/scoped_style/my_test.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A pkg/polymer/lib/boot.js View 1 1 chunk +188 lines, -0 lines 0 comments Download
A pkg/polymer/lib/component_build.dart View 1 1 chunk +166 lines, -0 lines 0 comments Download
A pkg/polymer/lib/dwc.dart View 1 1 chunk +198 lines, -0 lines 0 comments Download
A pkg/polymer/lib/observe.dart View 1 1 chunk +124 lines, -0 lines 0 comments Download
A pkg/polymer/lib/observe_html.dart View 1 1 chunk +63 lines, -0 lines 0 comments Download
A pkg/polymer/lib/polymer.dart View 1 1 chunk +143 lines, -0 lines 0 comments Download
A pkg/polymer/lib/polymer_element.dart View 1 1 chunk +555 lines, -0 lines 0 comments Download
A pkg/polymer/lib/safe_html.dart View 1 1 chunk +39 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/analyzer.dart View 1 1 chunk +566 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/compiler.dart View 1 1 chunk +770 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/compiler_options.dart View 1 1 chunk +148 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/css_analyzer.dart View 1 1 chunk +507 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/css_emitters.dart View 1 1 chunk +155 lines, -0 lines 0 comments Download
A + pkg/polymer/lib/src/custom_tag_name.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/polymer/lib/src/dart_parser.dart View 1 1 chunk +132 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/emitters.dart View 1 1 chunk +246 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/file_system.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/file_system/console.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/files.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/html5_utils.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/info.dart View 1 1 chunk +330 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/messages.dart View 1 1 chunk +149 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/paths.dart View 1 1 chunk +170 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/summary.dart View 1 1 chunk +88 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/utils.dart View 1 1 chunk +177 lines, -0 lines 0 comments Download
A pkg/polymer/lib/src/utils_observe.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/polymer/lib/testing/content_shell_test.dart View 1 1 chunk +229 lines, -0 lines 0 comments Download
A pkg/polymer/lib/testing/testing.js View 1 1 chunk +147 lines, -0 lines 0 comments Download
A pkg/polymer/pubspec.yaml View 1 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/polymer/test/compiler_test.dart View 1 1 chunk +140 lines, -0 lines 0 comments Download
A pkg/polymer/test/css_test.dart View 1 1 chunk +547 lines, -0 lines 0 comments Download
A pkg/polymer/test/data/unit/event_path_test.html View 1 1 chunk +142 lines, -0 lines 0 comments Download
A pkg/polymer/test/data/unit/events_test.html View 1 1 chunk +97 lines, -0 lines 0 comments Download
A pkg/polymer/test/paths_test.dart View 1 1 chunk +325 lines, -0 lines 0 comments Download
A pkg/polymer/test/run.sh View 1 1 chunk +134 lines, -0 lines 0 comments Download
A pkg/polymer/test/run_all.dart View 1 1 chunk +78 lines, -0 lines 0 comments Download
A pkg/polymer/test/testing.dart View 1 1 chunk +111 lines, -0 lines 0 comments Download
A pkg/polymer/test/utils_test.dart View 1 1 chunk +86 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/build.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 1 chunk +3 lines, -4 lines 0 comments Download
D samples/third_party/todomvc/test/expected/todomvc_listorder_shadowdom_test.html.txt View 1 1 chunk +0 lines, -171 lines 0 comments Download
M samples/third_party/todomvc/test/expected/todomvc_listorder_test.html.txt View 1 1 chunk +631 lines, -175 lines 0 comments Download
M samples/third_party/todomvc/test/expected/todomvc_mainpage2_test.html.txt View 1 1 chunk +376 lines, -135 lines 0 comments Download
M samples/third_party/todomvc/test/expected/todomvc_mainpage_test.html.txt View 1 1 chunk +242 lines, -85 lines 0 comments Download
M samples/third_party/todomvc/test/expected/todomvc_markdone_test.html.txt View 1 1 chunk +749 lines, -191 lines 0 comments Download
M samples/third_party/todomvc/test/test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
D samples/third_party/todomvc/test/todomvc_listorder_shadowdom_test.html View 1 1 chunk +0 lines, -63 lines 0 comments Download
M samples/third_party/todomvc/test/todomvc_listorder_test.html View 1 1 chunk +21 lines, -23 lines 0 comments Download
M samples/third_party/todomvc/test/todomvc_mainpage2_test.html View 1 1 chunk +5 lines, -8 lines 0 comments Download
M samples/third_party/todomvc/test/todomvc_mainpage_test.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M samples/third_party/todomvc/test/todomvc_markdone_test.html View 1 1 chunk +53 lines, -33 lines 0 comments Download
A samples/third_party/todomvc/web/app.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/web/app.html View 1 2 chunks +13 lines, -29 lines 0 comments Download
A samples/third_party/todomvc/web/editable_label.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/web/editable_label.html View 1 1 chunk +9 lines, -61 lines 0 comments Download
M samples/third_party/todomvc/web/index.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M samples/third_party/todomvc/web/model.dart View 1 1 chunk +50 lines, -32 lines 0 comments Download
A samples/third_party/todomvc/web/router_options.dart View 1 1 chunk +49 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/web/router_options.html View 1 1 chunk +3 lines, -39 lines 0 comments Download
A samples/third_party/todomvc/web/todo_row.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/web/todo_row.html View 1 3 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
Hi Siggi, This is the initial snapshot of the polymer pkg. Also updates the TodoMVC ...
7 years, 4 months ago (2013-08-20 03:23:54 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://chromiumcodereview.appspot.com/23224003/diff/102001/pkg/pkg.status File pkg/pkg.status (right): https://chromiumcodereview.appspot.com/23224003/diff/102001/pkg/pkg.status#newcode11 pkg/pkg.status:11: */*/*/*/packages/*/*: Skip we must go deeper!
7 years, 4 months ago (2013-08-20 22:25:35 UTC) #2
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/23224003/diff/102001/samples/third_party/todomvc/build.dart File samples/third_party/todomvc/build.dart (right): https://chromiumcodereview.appspot.com/23224003/diff/102001/samples/third_party/todomvc/build.dart#newcode10 samples/third_party/todomvc/build.dart:10: build(new Options().arguments, ['web/index.html']); you might need to add a ...
7 years, 4 months ago (2013-08-20 22:26:41 UTC) #3
Siggi Cherem (dart-lang)
On 2013/08/20 22:26:41, Siggi Cherem (dart-lang) wrote: > https://chromiumcodereview.appspot.com/23224003/diff/102001/samples/third_party/todomvc/build.dart > File samples/third_party/todomvc/build.dart (right): > > ...
7 years, 4 months ago (2013-08-20 22:27:38 UTC) #4
Jennifer Messerly
https://chromiumcodereview.appspot.com/23224003/diff/102001/samples/third_party/todomvc/build.dart File samples/third_party/todomvc/build.dart (right): https://chromiumcodereview.appspot.com/23224003/diff/102001/samples/third_party/todomvc/build.dart#newcode10 samples/third_party/todomvc/build.dart:10: build(new Options().arguments, ['web/index.html']); On 2013/08/20 22:26:41, Siggi Cherem (dart-lang) ...
7 years, 4 months ago (2013-08-20 22:47:32 UTC) #5
Jennifer Messerly
7 years, 4 months ago (2013-08-20 22:49:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r26404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698