Switch package waterfall to use package spec file, not package root.

Switch package waterfall to use package spec file, not package root.

BUG=https://github.com/dart-lang/sdk/issues/24093
R=lrn@google.com, mit@google.com

Committed: https://github.com/dart-lang/package-bots/commit/f582ad4a04bb2cc13604fe41274cbc8b655904e2

[Bill Hesse, 2016-08-12 11:53:37]

whesse@google.com changed reviewers:
+ mit@google.com

[Bill Hesse, 2016-08-12 11:55:46]

whesse@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-08-12 12:01:53]

lgtm

[mit, 2016-08-12 12:02:31]

lgtm with comments

https://codereview.chromium.org/2235233004/diff/1/annotated_steps.py
File annotated_steps.py (left):

https://codereview.chromium.org/2235233004/diff/1/annotated_steps.py#oldcode325
annotated_steps.py:325: # Note: we use package_name/package_name/folder and not
package_name/folder on
Should update this comment

https://codereview.chromium.org/2235233004/diff/1/trigger.txt
File trigger.txt (right):

https://codereview.chromium.org/2235233004/diff/1/trigger.txt#newcode9
trigger.txt:9: The rain comes down in torrents
s/torrents/cascades since torrents are not allowed at google

[Bill Hesse, 2016-08-12 12:06:00]

https://codereview.chromium.org/2235233004/diff/1/annotated_steps.py
File annotated_steps.py (left):

https://codereview.chromium.org/2235233004/diff/1/annotated_steps.py#oldcode325
annotated_steps.py:325: # Note: we use package_name/package_name/folder and not
package_name/folder on
On 2016/08/12 12:02:31, mit wrote:
> Should update this comment

The comment does not apply to the changed package path, but to the final
argument to test.py, which is the test selector and filter.

https://codereview.chromium.org/2235233004/diff/1/trigger.txt
File trigger.txt (right):

https://codereview.chromium.org/2235233004/diff/1/trigger.txt#newcode9
trigger.txt:9: The rain comes down in torrents
On 2016/08/12 12:02:31, mit wrote:
> s/torrents/cascades since torrents are not allowed at google

Sounds awkward.  How about

The lukewarm rain cascades down

[Bill Hesse, 2016-08-12 12:07:27]

Description was changed from

==========
Switch package waterfall to use package spec file, not package root.

BUG=https://github.com/dart-lang/sdk/issues/24093
==========

to

==========
Switch package waterfall to use package spec file, not package root.

BUG=https://github.com/dart-lang/sdk/issues/24093
R=lrn@google.com, mit@google.com

Committed:
https://github.com/dart-lang/package-bots/commit/f582ad4a04bb2cc13604fe41274c...
==========

[Bill Hesse, 2016-08-12 12:07:29]

Committed patchset #2 (id:20001) manually as
f582ad4a04bb2cc13604fe41274cbc8b655904e2 (presubmit successful).

[nweiz, 2016-08-12 19:58:14]

nweiz@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2016-08-12 19:58:14]

https://codereview.chromium.org/2235233004/diff/20001/annotated_steps.py
File annotated_steps.py (right):

https://codereview.chromium.org/2235233004/diff/20001/annotated_steps.py#newc...
annotated_steps.py:270: args = [pub, 'upgrade', '--no-package-symlinks']
Heads up: this flag is not yet public and it's very possible that the name will
change in the future.