Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2150323002: Add dart options for override annotations. (Closed)

Created:
4 years, 5 months ago by frederikmutzel
Modified:
4 years, 5 months ago
Reviewers:
skybrian
CC:
reviews_dartlang.org, Søren Gjesse
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart options for override annotations. These make it possible to tag generated getters, setters, clearX() and hasX() methods with "@override". R=skybrian@google.com Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/18ab9c733b940f2c5bead7491821e9751da8972b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -6 lines) Patch
M lib/message_generator.dart View 2 chunks +24 lines, -1 line 0 comments Download
M lib/protobuf_field.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M lib/src/dart_options.pb.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M test/protos/dart_options.proto View 1 chunk +13 lines, -0 lines 0 comments Download
M test/protos/mixins.proto View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
skybrian
LGTM I did not have time to land this today but I will do it ...
4 years, 5 months ago (2016-07-19 06:15:52 UTC) #3
skybrian
4 years, 5 months ago (2016-07-19 18:19:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18ab9c733b940f2c5bead7491821e9751da8972b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698