Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2108523003: update protoc README (Closed)

Created:
4 years, 5 months ago by skybrian
Modified:
4 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, frederikmutzel
Base URL:
git@github.com:dart-lang/dart-protoc-plugin.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update README Among other things, explicitly say that we require 2.6.1. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/a0475093622526658bef907b2c968a9b7221e3f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M README.md View 3 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
4 years, 5 months ago (2016-06-28 01:38:16 UTC) #2
Søren Gjesse
lgtm, but maybe add a comment about the Dart SDK to use (the dart2dart issue) ...
4 years, 5 months ago (2016-06-28 08:29:10 UTC) #3
skybrian
4 years, 5 months ago (2016-06-28 23:00:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0475093622526658bef907b2c968a9b7221e3f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698