Rename mixin protos and add a check for undefined mixin name

Rename mixin protos and add a check for undefined mixin name

ImportedMixins => Imports
imported_mixins => imports

Also regenerate checked-in code.

BUG=
R=frederikmutzel@google.com

Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/24dd6875c3b49b811714a735013cac5b2bd15f07

[skybrian, 2016-06-28 05:29:07]

skybrian@google.com changed reviewers:
+ frederikmutzel@google.com

[skybrian, 2016-06-28 05:29:08]

Followup from https://codereview.chromium.org/2086253002/

[frederikmutzel, 2016-06-28 08:15:13]

lgtm

https://codereview.chromium.org/2103743002/diff/1/lib/file_generator.dart
File lib/file_generator.dart (right):

https://codereview.chromium.org/2103743002/diff/1/lib/file_generator.dart#new...
lib/file_generator.dart:28: Imports importedMixins =
desc.options.getExtension(Dart_options.imports);
maybe rename the variable to imports as well?

https://codereview.chromium.org/2103743002/diff/1/lib/message_generator.dart
File lib/message_generator.dart (right):

https://codereview.chromium.org/2103743002/diff/1/lib/message_generator.dart#...
lib/message_generator.dart:22: throw throw '${desc.name} in ${file.name}: mixin
"$name" not found';
double throw

[skybrian, 2016-06-28 08:33:09]

Description was changed from

==========
Rename mixin protos and add a check for undefined mixin name

ImportedMixins => Imports
imported_mixins => imports

Also regenerate checked-in code.

BUG=
==========

to

==========
Rename mixin protos and add a check for undefined mixin name

ImportedMixins => Imports
imported_mixins => imports

Also regenerate checked-in code.

BUG=
R=frederikmutzel@google.com

Committed:
https://github.com/dart-lang/dart-protoc-plugin/commit/24dd6875c3b49b811714a7...
==========

[skybrian, 2016-06-28 08:33:10]

Committed patchset #1 (id:1) manually as
24dd6875c3b49b811714a735013cac5b2bd15f07 (presubmit successful).

[skybrian, 2016-06-28 08:40:35]

https://codereview.chromium.org/2103743002/diff/1/lib/file_generator.dart
File lib/file_generator.dart (right):

https://codereview.chromium.org/2103743002/diff/1/lib/file_generator.dart#new...
lib/file_generator.dart:28: Imports importedMixins =
desc.options.getExtension(Dart_options.imports);
On 2016/06/28 08:15:13, frederikmutzel wrote:
> maybe rename the variable to imports as well?

Skipping for now.

https://codereview.chromium.org/2103743002/diff/1/lib/message_generator.dart
File lib/message_generator.dart (right):

https://codereview.chromium.org/2103743002/diff/1/lib/message_generator.dart#...
lib/message_generator.dart:22: throw throw '${desc.name} in ${file.name}: mixin
"$name" not found';
On 2016/06/28 08:15:13, frederikmutzel wrote:
> double throw

Fixed.