Move server-side service stubs to .pbserver.dart

Move server-side service stubs to .pbserver.dart

This should break all dependencies on .pbjson.dart files for client-side
code, reducing the number of files loaded into Dartium.

However, it is a breaking API change: server-side code needs to be modified
to import .pbserver.dart files as well as .pb.dart files.

BUG=
R=sgjesse@google.com

Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/35b7464412cab501bf63b908cf9367e9a8fde306

[skybrian, 2016-05-27 03:04:53]

skybrian@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2016-05-27 07:34:35]

lgtm

https://codereview.chromium.org/2013343002/diff/20001/test/file_generator_tes...
File test/file_generator_test.dart (right):

https://codereview.chromium.org/2013343002/diff/20001/test/file_generator_tes...
test/file_generator_test.dart:335: class TestApi {
Have you considered to also split out the client side API to a .pbclient.dart
file? For the use-cases where the client side API is not used. The
.pbclient.dart could re-export some of the other stuff so that only one import
is required when using the client side API.

https://codereview.chromium.org/2013343002/diff/20001/test/service_test.dart
File test/service_test.dart (right):

https://codereview.chromium.org/2013343002/diff/20001/test/service_test.dart#...
test/service_test.dart:9: import '../out/protos/service.pbserver.dart' as pb;
If .pbserver.dart re-exported .pd.dart you only need one import.

[skybrian, 2016-05-27 18:26:20]

Description was changed from

==========
Move server-side service stubs to .pbserver.dart

This should break all dependencies on .pbjson.dart files for client-side
code, reducing the number of files loaded into Dartium.

However, it is a breaking API change: server-side code needs to be modified
to import .pbserver.dart files as well as .pb.dart files.

BUG=
==========

to

==========
Move server-side service stubs to .pbserver.dart

This should break all dependencies on .pbjson.dart files for client-side
code, reducing the number of files loaded into Dartium.

However, it is a breaking API change: server-side code needs to be modified
to import .pbserver.dart files as well as .pb.dart files.

BUG=
R=sgjesse@google.com

Committed:
https://github.com/dart-lang/dart-protoc-plugin/commit/35b7464412cab501bf63b9...
==========

[skybrian, 2016-05-27 18:26:21]

Committed patchset #2 (id:20001) manually as
35b7464412cab501bf63b908cf9367e9a8fde306 (presubmit successful).

[skybrian, 2016-05-27 18:27:50]

https://codereview.chromium.org/2013343002/diff/20001/test/file_generator_tes...
File test/file_generator_test.dart (right):

https://codereview.chromium.org/2013343002/diff/20001/test/file_generator_tes...
test/file_generator_test.dart:335: class TestApi {
On 2016/05/27 07:34:35, Søren Gjesse wrote:
> Have you considered to also split out the client side API to a .pbclient.dart
> file? For the use-cases where the client side API is not used. The
> .pbclient.dart could re-export some of the other stuff so that only one import
> is required when using the client side API.

I considered it but I'm not sure it would accomplish that much? Normally the
requests and responses are in the same .proto file, so the client-side stub
doesn't require any additional imports.

https://codereview.chromium.org/2013343002/diff/20001/test/service_test.dart
File test/service_test.dart (right):

https://codereview.chromium.org/2013343002/diff/20001/test/service_test.dart#...
test/service_test.dart:9: import '../out/protos/service.pbserver.dart' as pb;
On 2016/05/27 07:34:35, Søren Gjesse wrote:
> If .pbserver.dart re-exported .pd.dart you only need one import.

Done.