Issue 19235008: Rename package:js ports to avoid conflict with dart:js ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19235008: Rename package:js ports to avoid conflict with dart:js ones (Closed)

Created:
7 years, 5 months ago by vsm

Modified:
7 years, 5 months ago

Reviewers:
justinfagnani, alexandre.ardhuin

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/js-interop.git@master

Visibility:
Public.

More Reviews

Description

Rename package:js ports to avoid conflict with dart:js ones Eventually, this will go away as package:js is ported to dart:js. This seems to get package:js working against the new code in the browser package. Tested with and without script injection. R=justinfagnani@google.com Committed: https://github.com/dart-lang/js-interop/commit/ab930c8

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -45 lines)			Patch
M	lib/dart_interop.js	View	2 chunks	+14 lines, -14 lines	0 comments	Download
M	lib/js.dart	View	4 chunks	+29 lines, -29 lines	0 comments	Download
M	pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #1 manually as rab930c8 (presubmit successful).

7 years, 5 months ago (2013-07-16 01:14:23 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages