Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162403002: Remove docs and point to ones on dartlang.org. (Closed)

Created:
6 years, 10 months ago by Bob Nystrom
Modified:
6 years, 10 months ago
Reviewers:
nweiz
Base URL:
https://github.com/dart-lang/pub-dartlang.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Re-upload. #

Patch Set 3 : Re-upload. #

Patch Set 4 : Re-upload. #

Total comments: 2

Patch Set 5 : Fit in 80 columns. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8966 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M Gemfile View 1 chunk +0 lines, -3 lines 0 comments Download
M Gemfile.lock View 3 chunks +0 lines, -42 lines 0 comments Download
M Procfile View 1 chunk +0 lines, -1 line 0 comments Download
M README.md View 4 chunks +10 lines, -17 lines 0 comments Download
D _config.yml View 1 chunk +0 lines, -8 lines 0 comments Download
D app/doc/assets-and-transformers.graffle View 1 chunk +0 lines, -3920 lines 0 comments Download
D app/doc/assets-and-transformers.markdown View 1 chunk +0 lines, -186 lines 0 comments Download
D app/doc/dependencies.markdown View 1 chunk +0 lines, -281 lines 0 comments Download
D app/doc/faq.markdown View 1 chunk +0 lines, -137 lines 0 comments Download
D app/doc/glossary.markdown View 1 chunk +0 lines, -213 lines 0 comments Download
app/doc/index.markdown View 1 chunk +0 lines, -296 lines 0 comments Download
app/doc/package-layout.markdown View 1 chunk +0 lines, -362 lines 0 comments Download
app/doc/pub-build.markdown View 1 chunk +0 lines, -51 lines 0 comments Download
D app/doc/pub-cache.markdown View 1 chunk +0 lines, -15 lines 0 comments Download
app/doc/pub-get.markdown View 1 chunk +0 lines, -99 lines 0 comments Download
D app/doc/pub-lish.markdown View 1 chunk +0 lines, -91 lines 0 comments Download
D app/doc/pub-serve.markdown View 1 chunk +0 lines, -65 lines 0 comments Download
D app/doc/pub-upgrade.markdown View 1 chunk +0 lines, -76 lines 0 comments Download
app/doc/pub-uploader.markdown View 1 chunk +0 lines, -30 lines 0 comments Download
D app/doc/pubspec.markdown View 1 chunk +0 lines, -184 lines 0 comments Download
D app/doc/versioning.markdown View 1 chunk +0 lines, -379 lines 0 comments Download
D app/handlers/doc.py View 1 chunk +0 lines, -59 lines 0 comments Download
M app/pub_dartlang.py View 2 chunks +0 lines, -5 lines 0 comments Download
D app/views/doc/assets-and-transformers.html View 1 chunk +0 lines, -182 lines 0 comments Download
D app/views/doc/dependencies.html View 1 chunk +0 lines, -267 lines 0 comments Download
D app/views/doc/faq.html View 1 chunk +0 lines, -116 lines 0 comments Download
D app/views/doc/glossary.html View 1 chunk +0 lines, -211 lines 0 comments Download
D app/views/doc/index.html View 1 chunk +0 lines, -298 lines 0 comments Download
D app/views/doc/package-layout.html View 1 chunk +0 lines, -368 lines 0 comments Download
D app/views/doc/pub-build.html View 1 chunk +0 lines, -51 lines 0 comments Download
D app/views/doc/pub-cache.html View 1 chunk +0 lines, -12 lines 0 comments Download
D app/views/doc/pub-get.html View 1 chunk +0 lines, -96 lines 0 comments Download
D app/views/doc/pub-lish.html View 1 chunk +0 lines, -93 lines 0 comments Download
D app/views/doc/pub-serve.html View 1 chunk +0 lines, -66 lines 0 comments Download
D app/views/doc/pub-upgrade.html View 1 chunk +0 lines, -75 lines 0 comments Download
D app/views/doc/pub-uploader.html View 1 chunk +0 lines, -29 lines 0 comments Download
D app/views/doc/pubspec.html View 1 chunk +0 lines, -174 lines 0 comments Download
D app/views/doc/versioning.html View 1 chunk +0 lines, -372 lines 0 comments Download
M app/views/index.mustache View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M app/views/layout.mustache View 1 chunk +15 lines, -15 lines 0 comments Download
M app/views/packages/show.mustache View 1 chunk +2 lines, -2 lines 0 comments Download
M app/views/site_map.mustache View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
6 years, 10 months ago (2014-02-13 00:57:11 UTC) #1
nweiz
One suggestion, otherwise lgtm. https://chromiumcodereview.appspot.com/162403002/diff/100001/app/views/index.mustache File app/views/index.mustache (right): https://chromiumcodereview.appspot.com/162403002/diff/100001/app/views/index.mustache#newcode13 app/views/index.mustache:13: <a class="get-started" href="https://www.dartlang.org/tools/pub/get-started.html">Get started</a> It ...
6 years, 10 months ago (2014-02-14 02:57:12 UTC) #2
Bob Nystrom
https://chromiumcodereview.appspot.com/162403002/diff/100001/app/views/index.mustache File app/views/index.mustache (right): https://chromiumcodereview.appspot.com/162403002/diff/100001/app/views/index.mustache#newcode13 app/views/index.mustache:13: <a class="get-started" href="https://www.dartlang.org/tools/pub/get-started.html">Get started</a> On 2014/02/14 02:57:12, nweiz wrote: ...
6 years, 10 months ago (2014-02-14 22:10:21 UTC) #3
Bob Nystrom
6 years, 10 months ago (2014-02-14 23:06:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as re2ab489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698