Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 140303004: Added polymer internationalization sample (Closed)

Created:
6 years, 11 months ago by shailentuli
Modified:
6 years, 11 months ago
Reviewers:
Kathy Walrath
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Added polymer internationalization sample R=kathyw@google.com Committed: bd6a86f

Patch Set 1 #

Total comments: 4

Patch Set 2 : Small changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32253 lines, -16 lines) Patch
A src/site/samples/polymer_intl/example/intl_messages.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A + src/site/samples/polymer_intl/example/polymer_intl.css View 1 2 chunks +3 lines, -16 lines 0 comments Download
A src/site/samples/polymer_intl/example/polymer_intl.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/example/polymer_intl.html_bootstrap.dart.js View 1 1 chunk +13155 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/example/polymer_intl.html_bootstrap.dart.js.map View 1 1 chunk +7 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/example/polymer_intl.html_bootstrap.dart.precompiled.js View 1 1 chunk +19015 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/example/translation_fr.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/example/translation_pt.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
A src/site/samples/polymer_intl/index.markdown View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/site/samples/samples.yaml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shailentuli
I've added the polymer internationalization sample. PTAL. Staged at https://intl-dot-dart-lang.appspot.com/samples/
6 years, 11 months ago (2014-01-24 16:16:29 UTC) #1
Kathy Walrath
Looks good! Just a couple of nits. Also, in the dart repo's README.md (pointed to ...
6 years, 11 months ago (2014-01-24 17:48:25 UTC) #2
shailentuli
I'll make the changes in the actual sample in a separate CL, but I've made ...
6 years, 11 months ago (2014-01-27 17:07:15 UTC) #3
Kathy Walrath
lgtm
6 years, 11 months ago (2014-01-27 18:06:17 UTC) #4
shailentuli
6 years, 11 months ago (2014-01-27 19:07:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as rbd6a86f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698