Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1378193004: Fix Analysis Engine plugin setup. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M lib/src/driver.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M test/driver_test.dart View 3 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-01 00:04:21 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-01 00:05:45 UTC) #3
pquitslund
5 years, 2 months ago (2015-10-01 00:07:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35cb902c75dc67a8f33b68355bc9e37e0dc9823f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698