Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1355203002: Handle index expressions in the middle of call chains. (Closed)

Created:
5 years, 3 months ago by Bob Nystrom
Modified:
5 years, 3 months ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle index expressions in the middle of call chains. R=pquitslund@google.com Committed: 619dfbf1f73fe55b0ea071c67a9cea9f0f951609

Patch Set 1 #

Patch Set 2 : Update CHANGELOG. #

Patch Set 3 : Handle chained indexes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -27 lines) Patch
M CHANGELOG.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M example/format.dart View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M lib/src/call_chain_visitor.dart View 1 2 3 chunks +27 lines, -19 lines 0 comments Download
M lib/src/source_visitor.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M test/regression/other/analysis_server.unit View 1 chunk +13 lines, -1 line 0 comments Download
M test/splitting/invocations.stmt View 1 2 1 chunk +31 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
5 years, 3 months ago (2015-09-21 19:59:22 UTC) #2
pquitslund
lgtm
5 years, 3 months ago (2015-09-21 21:36:56 UTC) #3
Bob Nystrom
5 years, 3 months ago (2015-09-21 22:01:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
619dfbf1f73fe55b0ea071c67a9cea9f0f951609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698