Issue 1258203006: Handle function arguments inside function calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1258203006: Handle function arguments inside function calls. (Closed)

Created:
5 years, 4 months ago by Bob Nystrom

Modified:
5 years, 4 months ago

Reviewers:
pquitslund, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Handle function arguments inside function calls. Fixes #366. Also, I'm calling it. This is the 0.2.0 release. R=kevmoo@google.com, pquitslund@google.com Committed: 45682252b977c4408dc673aeaa0039845ea1f718

Patch Set 1 #

Patch Set 2 : Reformat self. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -77 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/argument_list_visitor.dart	View	1	5 chunks	+32 lines, -10 lines	0 comments	Download
M	lib/src/line_splitting/solve_state.dart	View	1	3 chunks	+15 lines, -18 lines	0 comments	Download
M	lib/src/rule/argument.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/src/source_visitor.dart	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/formatter_test.dart	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
M	test/regression/0100/0108.unit	View		1 chunk	+6 lines, -14 lines	0 comments	Download
A	test/regression/0300/0366.stmt	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/splitting/function_arguments.stmt	View		1 chunk	+13 lines, -17 lines	0 comments	Download
M	test/splitting/mixed.stmt	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

5 years, 4 months ago (2015-07-30 21:19:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
45682252b977c4408dc673aeaa0039845ea1f718 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages