Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1257443002: Split before "deferred" if present. (Closed)

Created:
5 years, 5 months ago by Bob Nystrom
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split before "deferred" if present. Fix #381. R=kevmoo@google.com Committed: 8b4043335624f6963d8fc732259aed7d008f3b07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -114 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +8 lines, -3 lines 0 comments Download
A test/regression/0300/0381.unit View 1 chunk +5 lines, -0 lines 0 comments Download
D test/regression/139.unit View 1 chunk +0 lines, -45 lines 0 comments Download
D test/regression/361.unit View 1 chunk +0 lines, -66 lines 0 comments Download
M test/splitting/imports.unit View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
(The two deleted tests are old redundant copies of the tests that were moved into ...
5 years, 5 months ago (2015-07-23 19:29:10 UTC) #2
kevmoo
lgtm
5 years, 5 months ago (2015-07-23 19:40:41 UTC) #3
Bob Nystrom
5 years, 5 months ago (2015-07-23 20:00:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b4043335624f6963d8fc732259aed7d008f3b07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698