Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1252323003: Allow arguments before and after block-formatted functions. (Closed)

Created:
5 years, 4 months ago by Bob Nystrom
Modified:
5 years, 4 months ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow arguments before and after block-formatted functions. This treats functions differently from collection literal arguments. After testing this on a large corpus, that seems to produce the best output. With this change, the arguments preceding and following a series of functions are treated as completely independent argument lists, each with their own splitting choice. Fixes #369. R=pquitslund@google.com Committed: 2e1164d6408cc18e532dee98e157e80c2514d692

Patch Set 1 #

Patch Set 2 : Update pubspec and changelog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -252 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/argument_list_visitor.dart View 4 chunks +251 lines, -144 lines 0 comments Download
M lib/src/chunk.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/rule/argument.dart View 10 chunks +73 lines, -76 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/regression/0000/0000.stmt View 1 chunk +1 line, -2 lines 0 comments Download
M test/regression/0000/0050.stmt View 1 chunk +2 lines, -4 lines 0 comments Download
M test/regression/0000/0057.stmt View 1 chunk +5 lines, -2 lines 0 comments Download
A test/regression/0300/0369.stmt View 1 chunk +26 lines, -0 lines 0 comments Download
M test/regression/other/analysis_server.unit View 1 chunk +60 lines, -0 lines 0 comments Download
M test/splitting/arguments.stmt View 2 chunks +4 lines, -5 lines 0 comments Download
M test/splitting/function_arguments.stmt View 2 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
With luck, this will be the last issue to fix for 0.2.0.
5 years, 4 months ago (2015-07-30 06:29:33 UTC) #2
pquitslund
lgtm
5 years, 4 months ago (2015-07-30 16:05:52 UTC) #3
Bob Nystrom
5 years, 4 months ago (2015-07-30 16:09:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2e1164d6408cc18e532dee98e157e80c2514d692 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698