Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1246413003: Allow splitting between adjacent strings. (Closed)

Created:
5 years, 5 months ago by Bob Nystrom
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow splitting between adjacent strings. Fixes #201 BUG= https://github.com/dart-lang/dart_style/issues/201 R=kevmoo@google.com Committed: 7db91c53b9c5cd91fb07302f896742314555dfb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/chunk_builder.dart View 3 chunks +12 lines, -1 line 0 comments Download
M lib/src/source_visitor.dart View 2 chunks +12 lines, -1 line 0 comments Download
M lib/src/whitespace.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A test/regression/0200/0201.stmt View 1 chunk +11 lines, -0 lines 0 comments Download
M test/splitting/expressions.stmt View 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
5 years, 5 months ago (2015-07-23 23:43:05 UTC) #2
kevmoo
WOO HOO! LGTM
5 years, 5 months ago (2015-07-23 23:45:49 UTC) #3
Bob Nystrom
5 years, 5 months ago (2015-07-23 23:58:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7db91c53b9c5cd91fb07302f896742314555dfb7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698