Issue 1188933002: Add regression tests for bugs that are working now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188933002: Add regression tests for bugs that are working now. (Closed)

Created:
5 years, 6 months ago by Bob Nystrom

Modified:
5 years, 6 months ago

Reviewers:
pquitslund, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add regression tests for bugs that are working now. (They were fixed by some combination of the previous commits.) Fix #204. Fix #206. Fix #249. R=kevmoo@google.com Committed: 0a792af4d5cc146d385efca2f29ad3d4a15ff227

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -0 lines)			Patch
A	test/regression/198.stmt	View	1 chunk	+54 lines, -0 lines	0 comments	Download
A	test/regression/204.stmt	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	test/regression/206.stmt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/regression/249.stmt	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

This also has the changes from https://chromiumcodereview.appspot.com/1191833002/, which you can ignore here. The only interesting ...

5 years, 6 months ago (2015-06-16 22:53:26 UTC) #2

Bob Nystrom

5 years, 6 months ago (2015-06-16 23:30:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0a792af4d5cc146d385efca2f29ad3d4a15ff227 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages