Issue 1183633004: Harden named arguments if a hard split occurs in the positional ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183633004: Harden named arguments if a hard split occurs in the positional ones. (Closed)

Created:
5 years, 6 months ago by Bob Nystrom

Modified:
5 years, 6 months ago

Reviewers:
pquitslund, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Harden named arguments if a hard split occurs in the positional ones. Fix #189. R=pquitslund@google.com Committed: 124a0f38124cd05848405f77c1efc49fbac31b5b

Patch Set 1 #

Patch Set 2 : Update changelog. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -4 lines)			Patch
M	CHANGELOG.md	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	lib/src/chunk_builder.dart	View		3 chunks	+18 lines, -1 line	0 comments	Download
M	test/comments/expressions.stmt	View		1 chunk	+10 lines, -1 line	0 comments	Download
A	test/regression/189.stmt	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	test/splitting/function_arguments.stmt	View		1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

5 years, 6 months ago (2015-06-16 21:52:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
124a0f38124cd05848405f77c1efc49fbac31b5b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages