Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182953003: Eat some dogfood! (Closed)

Created:
5 years, 6 months ago by Bob Nystrom
Modified:
5 years, 6 months ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eat some dogfood! R=kevmoo@google.com Committed: efd38861e3e88a1694c85094c4647018d2e71ff7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -199 lines) Patch
M benchmark/benchmark.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M bin/format.dart View 3 chunks +28 lines, -18 lines 0 comments Download
M lib/src/argument_list_visitor.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M lib/src/call_chain_visitor.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/src/chunk.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/chunk_builder.dart View 6 chunks +20 lines, -15 lines 0 comments Download
M lib/src/debug.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/line_prefix.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M lib/src/line_splitter.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M lib/src/line_writer.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M lib/src/nesting.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/rule/argument.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M lib/src/source_code.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/source_visitor.dart View 8 chunks +39 lines, -30 lines 2 comments Download
M test/command_line_test.dart View 3 chunks +9 lines, -27 lines 0 comments Download
M test/formatter_test.dart View 6 chunks +19 lines, -22 lines 0 comments Download
M test/io_test.dart View 6 chunks +19 lines, -48 lines 0 comments Download
M test/source_code_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M web/main.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
It's finally good enough that I don't mind running it on itself!
5 years, 6 months ago (2015-06-15 20:50:37 UTC) #2
kevmoo
LGTM w/ a couple of long lines https://chromiumcodereview.appspot.com/1182953003/diff/1/lib/src/source_visitor.dart File lib/src/source_visitor.dart (right): https://chromiumcodereview.appspot.com/1182953003/diff/1/lib/src/source_visitor.dart#newcode1644 lib/src/source_visitor.dart:1644: // Always ...
5 years, 6 months ago (2015-06-15 20:55:45 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as efd38861e3e88a1694c85094c4647018d2e71ff7 (presubmit successful).
5 years, 6 months ago (2015-06-15 21:04:17 UTC) #4
Bob Nystrom
5 years, 6 months ago (2015-06-15 21:04:54 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1182953003/diff/1/lib/src/source_visit...
File lib/src/source_visitor.dart (right):

https://chromiumcodereview.appspot.com/1182953003/diff/1/lib/src/source_visit...
lib/src/source_visitor.dart:1644: // Always use a hard rule to split the
elements. The parent chunk of the
On 2015/06/15 20:55:45, kevmoo wrote:
> long lines

Done.

Powered by Google App Engine
This is Rietveld 408576698