Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1173663004: Insert a blank line before and after classes. (Closed)

Created:
5 years, 6 months ago by Bob Nystrom
Modified:
5 years, 6 months ago
Reviewers:
pquitslund, kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Insert a blank line before and after classes. Fix #168. R=kevmoo@google.com Committed: 6eec571c9f1c940d55fbe524a5e8da3765ef0bde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +19 lines, -2 lines 0 comments Download
A test/regression/168.unit View 1 chunk +7 lines, -0 lines 0 comments Download
M test/whitespace/compilation_unit.unit View 2 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
Thanks for keeping up with my giant patch storm!
5 years, 6 months ago (2015-06-10 20:24:38 UTC) #2
kevmoo
lgtm
5 years, 6 months ago (2015-06-10 21:08:09 UTC) #3
Bob Nystrom
5 years, 6 months ago (2015-06-10 21:42:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6eec571c9f1c940d55fbe524a5e8da3765ef0bde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698