Issue 11471037: Updating dwc for breaking changes that will be part of the next sdk

Issue 11471037: Updating dwc for breaking changes that will be part of the next sdk (Closed)

Created:
8 years ago by Siggi Cherem (dart-lang)

Modified:
8 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-web-components.git@master

Visibility:
Public.

More Reviews

Description

Updating dwc for breaking changes that will be part of the next sdk Committed: https://github.com/dart-lang/web-ui/commit/7e91a26

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -25 lines)			Patch
M	CHANGELOG.md	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	bin/dwc_browser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/gen_html_setters.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	example/explainer/fruitsearch.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/file_system/browser.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/src/html5_setters.g.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/html5_utils.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/web_components.dart	View		4 chunks	+4 lines, -10 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/analyzer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/11471037/diff/1/lib/src/utils.dart File lib/src/utils.dart (right): https://chromiumcodereview.appspot.com/11471037/diff/1/lib/src/utils.dart#newcode5 lib/src/utils.dart:5: library web_components.utils; apparently now it is an error to ...

8 years ago (2012-12-07 19:31:45 UTC) #1

Jennifer Messerly

https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/fruitsearch.html File example/explainer/fruitsearch.html (right): https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/fruitsearch.html#newcode45 example/explainer/fruitsearch.html:45: (v) => v.toLowerCase().contains(query.toLowerCase())) as List<String>; nit: put type annotation ...

8 years ago (2012-12-07 20:31:57 UTC) #2

Jennifer Messerly

On 2012/12/07 20:31:57, John Messerly wrote: > https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/fruitsearch.html > File example/explainer/fruitsearch.html (right): > > https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/fruitsearch.html#newcode45 ...

8 years ago (2012-12-07 20:32:14 UTC) #3

Siggi Cherem (dart-lang)

8 years ago (2012-12-18 03:10:00 UTC) #4

Message was sent while issue was closed.

(stale comments, just sending it to clear my pending cls)

https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/frui...
File example/explainer/fruitsearch.html (right):

https://chromiumcodereview.appspot.com/11471037/diff/1/example/explainer/frui...
example/explainer/fruitsearch.html:45: (v) =>
v.toLowerCase().contains(query.toLowerCase())) as List<String>;
On 2012/12/07 20:31:57, John Messerly wrote:
> nit: put type annotation on LHS :)
> 
> List<String> res = ...

:)... good point.

https://chromiumcodereview.appspot.com/11471037/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://chromiumcodereview.appspot.com/11471037/diff/1/lib/src/utils.dart#new...
lib/src/utils.dart:5: library web_components.utils;
On 2012/12/07 20:31:57, John Messerly wrote:
> On 2012/12/07 19:31:46, Siggi Cherem (dart-lang) wrote:
> > apparently now it is an error to import 2 libraries with the same name.
> > 'emitter' imports this and html5lib/src/utils... 
> 
> We should follow up on that.
> fwiw, I think this should be "web_components.src.utils"

Done.

Expand Messages | Collapse Messages