Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 114323003: Use BytesBuilder for turning a byte stream into a list of bytes (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master
Visibility:
Public.

Description

Use BytesBuilder for turning a byte stream into a list of bytes R=ajohnsen@google.com Committed: https://github.com/dart-lang/protoc-plugin/commit/5e582e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M lib/code_generator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years ago (2013-12-19 12:02:25 UTC) #1
Søren Gjesse
7 years ago (2013-12-19 12:02:49 UTC) #2
Anders Johnsen
lgtm
7 years ago (2013-12-19 12:04:23 UTC) #3
Søren Gjesse
7 years ago (2013-12-19 12:10:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r5e582e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698