Issue 11360149: Report errors on duplicate export.

Issue 11360149: Report errors on duplicate export. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report errors on duplicate export. Committed: https://code.google.com/p/dart/source/detail?r=14737

Patch Set 2 : Updated cf. comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -11 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View		3 chunks	+17 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A	tests/language/duplicate_export_negative_test.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	tests/language/duplicate_import_liba.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A	tests/language/duplicate_import_libb.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A	tests/language/duplicate_import_libc.dart	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	tests/language/duplicate_import_libd.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.status#newcode113 tests/co19/co19-dart2dart.status:113: #Language/13_Libraries_and_Scripts/2_Exports_A04_t01: Fail # TODO(dart2dart-team): Please triage this failure. ...

8 years, 1 month ago (2012-11-09 11:49:50 UTC) #3

karlklose

https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.status#newcode113 tests/co19/co19-dart2dart.status:113: #Language/13_Libraries_and_Scripts/2_Exports_A04_t01: Fail # TODO(dart2dart-team): Please triage this failure. Please ...

8 years, 1 month ago (2012-11-09 11:50:38 UTC) #4

Johnni Winther

8 years, 1 month ago (2012-11-09 12:32:09 UTC) #5

https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/11360149/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:113:
#Language/13_Libraries_and_Scripts/2_Exports_A04_t01: Fail #
TODO(dart2dart-team): Please triage this failure.
On 2012/11/09 11:50:38, karlklose wrote:
> Please remove the lines.

Done.

https://codereview.chromium.org/11360149/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11360149/diff/1/tests/language/language.statu...
tests/language/language.status:150: duplicate_export_negative_test: Fail #
Duplicate export not reported.
On 2012/11/09 11:50:38, karlklose wrote:
> Duplicated status?

No. This is dartc, the one above is the VM.

Expand Messages | Collapse Messages