Issue 11085092: Revert "Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug." and 5 subsequent at…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11085092: Revert "Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug." and 5 subsequent at… (Closed)

Created:
8 years, 2 months ago by aam-me

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug." and 5 subsequent attempts to fix the build. This reverts r13582, r13573, r13572, r13564, r13562, r13557. TBR=ahe Committed: https://code.google.com/p/dart/source/detail?r=13585

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -221 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1 chunk	+11 lines, -29 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	8 chunks	+77 lines, -163 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/types/concrete_types_inferrer.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/types/types.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/universe/universe.dart	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/resolver_test.dart	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM :-(

Expand Messages | Collapse Messages