Issue 10933046: Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10933046: Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr. (Closed)

Created:
8 years, 3 months ago by Florian Schneider

Modified:
8 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr. They already have the same code generation template and LoadVMField contains all necessary information. Committed: https://code.google.com/p/dart/source/detail?r=12274

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -80 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+4 lines, -2 lines	2 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with one comment https://chromiumcodereview.appspot.com/10933046/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10933046/diff/1/runtime/vm/flow_graph_builder.cc#newcode2134 runtime/vm/flow_graph_builder.cc:2134: LoadVMFieldInstr* load = new LoadVMFieldInstr( ...

8 years, 3 months ago (2012-09-12 17:22:34 UTC) #2

Florian Schneider

8 years, 3 months ago (2012-09-12 17:31:16 UTC) #3

https://chromiumcodereview.appspot.com/10933046/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10933046/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:2134: LoadVMFieldInstr* load = new
LoadVMFieldInstr(
On 2012/09/12 17:22:34, srdjan wrote:
> Name is not good, since VM field denotes a field that is not representable in
> Dart. Maybe Merge LoadVMField and LoadInstanceField to LoadField?

Done.

Expand Messages | Collapse Messages