Add immediate operand support for indexed operations.

Add immediate operand support for indexed operations.

The value and/or the index of indexed loads/stores can
be emitted as immediate operands to reduce the number
of registers needed when constants are used.
Committed: https://code.google.com/p/dart/source/detail?r=12265

[Vyacheslav Egorov (Google), 2012-09-12 12:55:06]

lgtm

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:867: static bool
CanBeIndexImmediate(Value* index) {
CanBeImmediateIndex?

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:890: static int32_t RawSmi(const
Object& constant) {
I don't like that the name clashes with RawSmi class.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:906: int32_t disp =
RawSmi(locs()->in(1).constant()) * 2 + sizeof(RawArray);
How about just Smi::Cast(locs()->in(1).constant()).Value() * kWordSize here?
(just like in CanBeIndexImm...)

also const uint32_t disp

the same on x64

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:935: RawSmi(locs()->in(1).constant()) *
2 + sizeof(RawArray))
see above.

[srdjan, 2012-09-12 12:56:16]

DBC

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:890: static int32_t RawSmi(const
Object& constant) {
RawSmi is the name of the raw smi object. I would rename it. Why not use
Smi::RawValue(Smi::Cast(constant) instead?

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:906: int32_t disp =
RawSmi(locs()->in(1).constant()) * 2 + sizeof(RawArray);
You could get also Smi::Value(...)do * 4.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:886: const Smi& smi_const =
Smi::Cast(constant);
The reason why this works is because this code must have been run before
successfully, therefore the constant must be Smi. Correct?

[Florian Schneider, 2012-09-12 13:28:35]

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:867: static bool
CanBeIndexImmediate(Value* index) {
On 2012/09/12 12:55:06, Vyacheslav Egorov (Google) wrote:
> CanBeImmediateIndex?

Done.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:890: static int32_t RawSmi(const
Object& constant) {
On 2012/09/12 12:56:16, srdjan wrote:
> RawSmi is the name of the raw smi object. I would rename it. Why not use
> Smi::RawValue(Smi::Cast(constant) instead?

Removed and replaced with Smi::Cast(...) instead.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:906: int32_t disp =
RawSmi(locs()->in(1).constant()) * 2 + sizeof(RawArray);
On 2012/09/12 12:55:06, Vyacheslav Egorov (Google) wrote:
> How about just Smi::Cast(locs()->in(1).constant()).Value() * kWordSize here?
> (just like in CanBeIndexImm...)
> 
> also const uint32_t disp
> 
> the same on x64

Done. Using Smi::Value() * kWordSize.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:935: RawSmi(locs()->in(1).constant()) *
2 + sizeof(RawArray))
On 2012/09/12 12:55:06, Vyacheslav Egorov (Google) wrote:
> see above.

Done.

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10933045/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:886: const Smi& smi_const =
Smi::Cast(constant);
On 2012/09/12 12:56:16, srdjan wrote:
> The reason why this works is because this code must have been run before
> successfully, therefore the constant must be Smi. Correct?

Yes, and when optimizing we generate a smi-check for the index (which is
eliminated if the constant is indeed a smi).